Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use openssl 3.1.1 for Windows build #34795

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

yihau
Copy link
Member

@yihau yihau commented Jan 16, 2024

Problem

the latest openssl (3.2.0) broke Windows builds:

https://github.com/solana-labs/solana/actions/runs/7537712991/job/20517067308

Summary of Changes

use 3.1.1 (the previous version) for Windows builds.

@yihau yihau added automerge Merge this Pull Request automatically once CI passes v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17 labels Jan 16, 2024
Copy link
Contributor

mergify bot commented Jan 16, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link
Contributor

mergify bot commented Jan 16, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@agshuman

This comment was marked as off-topic.

@mergify mergify bot merged commit 0e90e98 into solana-labs:master Jan 16, 2024
18 checks passed
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
mergify bot pushed a commit that referenced this pull request Jan 16, 2024
yihau added a commit that referenced this pull request Jan 17, 2024
mergify bot added a commit that referenced this pull request Jan 17, 2024
…34796)

ci: use openssl 3.1.1 for Windows build (#34795)

(cherry picked from commit 0e90e98)

Co-authored-by: Yihau Chen <a122092487@gmail.com>
mergify bot added a commit that referenced this pull request Jan 17, 2024
…34797)

ci: use openssl 3.1.1 for Windows build (#34795)

(cherry picked from commit 0e90e98)

Co-authored-by: Yihau Chen <a122092487@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants