Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioned message json deserialization #34808

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jan 17, 2024

Problem

Versioned message deserialization is broken when using serde_json because serde_json expects the versioned message visitor to handle a u64 rather than a u8.

Summary of Changes

  • Update the message prefix visitor to implement visit_u64 instead of visit_u8
  • Add tests

Fixes #34608

@jstarry jstarry requested a review from 2501babe January 17, 2024 14:25
@jstarry jstarry added the v1.17 PRs that should be backported to v1.17 label Jan 17, 2024
Copy link
Contributor

mergify bot commented Jan 17, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (711215f) 81.8% compared to head (49fbd7d) 81.8%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34808     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         825      825             
  Lines      223124   223129      +5     
=========================================
- Hits       182525   182523      -2     
- Misses      40599    40606      +7     

@semgoSE
Copy link

semgoSE commented Jan 17, 2024

We are looking forward to it

@jstarry jstarry merged commit 747df9c into solana-labs:master Jan 18, 2024
46 checks passed
@jstarry jstarry deleted the fix/versioned-msg-json-deser branch January 18, 2024 02:31
mergify bot pushed a commit that referenced this pull request Jan 18, 2024
jstarry added a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialising a JSON-serialized VersionedTransaction fails
3 participants