harden bank tests #34821
Merged
harden bank tests #34821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34821 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 826 826
Lines 223237 223267 +30
=======================================
+ Hits 182457 182506 +49
+ Misses 40780 40761 -19 |
tao-stones
force-pushed
the
harden-bank-tests
branch
from
2d6d919
to
57a20e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some bank tests are set up with no-fee no-rent, others requires rent but no-fee, yet others are OK with FeeRateGovernor::default() and Rent::default().
In preparation of removing a multiplier used by tests in calculate_fee(), these tests should be updated to be explicit on what fee rate and rent should be when creating genesis_config.
Summary of Changes
Fixes #