Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces fs-err in tiered storage #34859

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Replaces fs-err in tiered storage #34859

merged 1 commit into from
Jan 19, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838

Summary of Changes

Replace fs_err with std::fs

@brooksprumo brooksprumo self-assigned this Jan 19, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 19, 2024 19:10
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (9d13244) 81.7% compared to head (2e3e6a5) 81.7%.
Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #34859   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         826      826           
  Lines      223114   223190   +76     
=======================================
+ Hits       182335   182424   +89     
+ Misses      40779    40766   -13

yhchiang-sol
yhchiang-sol approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks!

@brooksprumo brooksprumo merged commit 3916c31 into solana-labs:master Jan 19, 2024
35 checks passed
@brooksprumo brooksprumo deleted the fs-err/accounts-db/ts branch January 19, 2024 22:16
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhchiang-sol yhchiang-sol yhchiang-sol approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @yhchiang-sol