Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces fs-err in verify_snapshot_archive() #34887

Conversation

brooksprumo
Copy link
Contributor

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838.

Some uses of fs-err in snapshot_utils.rs can easily be replaced with their std::fs counterparts.

Summary of Changes

Replace 'em. Note that all these uses are in a DCOU fn, so test-only.

@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 22, 2024 21:47
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f9bfb60) 81.7% compared to head (03f0006) 81.7%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34887     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         826      826             
  Lines      223371   223383     +12     
=========================================
- Hits       182578   182567     -11     
- Misses      40793    40816     +23     

@brooksprumo brooksprumo merged commit 8cfad7f into solana-labs:master Jan 22, 2024
35 checks passed
@brooksprumo brooksprumo deleted the errors/fs-err/verify-snapshot-archive branch January 22, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants