Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some minimum number of streams for a staked connection - v1.17 #34894

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Jan 23, 2024

Problem

A low staked peer may not be able to open any QUIC streams.

Summary of Changes

Allow a minimum number of QUIC streams for a staked connection.

Fixes #

@pgarg66 pgarg66 requested a review from t-nelson January 23, 2024 00:09
@t-nelson t-nelson changed the title Allow some minimum number of streams for a staked connection Allow some minimum number of streams for a staked connection - v1.17 Jan 23, 2024
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. the ema method in master handles this case gracefully, right?

@pgarg66
Copy link
Contributor Author

pgarg66 commented Jan 23, 2024

lgtm. the ema method in master handles this case gracefully, right?

Yes, EMA method ensures that staked connections get at least 1 more streams than unstaked connections.

@pgarg66
Copy link
Contributor Author

pgarg66 commented Jan 23, 2024

blocked on #34880

@pgarg66 pgarg66 marked this pull request as ready for review January 23, 2024 22:28
@joncinque
Copy link
Contributor

And now blocked on #34920

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74b0830) 81.7% compared to head (de962cc) 81.7%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34894     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         806      806             
  Lines      218925   218928      +3     
=========================================
- Hits       178887   178876     -11     
- Misses      40038    40052     +14     

@pgarg66 pgarg66 merged commit de8415c into solana-labs:v1.17 Jan 24, 2024
33 checks passed
@pgarg66 pgarg66 deleted the v1.17 branch January 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants