-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - LoadedPrograms statistics #35026
Conversation
3e26fff
to
e426a16
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35026 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 830 830
Lines 224828 224837 +9
=========================================
- Hits 183521 183509 -12
- Misses 41307 41328 +21 |
1fd11d4
to
8513159
Compare
Adds reloads, lost_insertions. Removes prunes_expired.
8513159
to
55160b3
Compare
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Fixes hits, misses. Adds reloads, lost_insertions. Removes prunes_expired. (cherry picked from commit 5dd9609) # Conflicts: # program-runtime/src/loaded_programs.rs
Fixes hits, misses. Adds reloads, lost_insertions. Removes prunes_expired. (cherry picked from commit 5dd9609) # Conflicts: # program-runtime/src/loaded_programs.rs
Fixes hits, misses. Adds reloads, lost_insertions. Removes prunes_expired. (cherry picked from commit 5dd9609)
Fixes hits, misses. Adds reloads, lost_insertions. Removes prunes_expired. (cherry picked from commit 5dd9609)
Fixes hits, misses. Adds reloads, lost_insertions. Removes prunes_expired. (cherry picked from commit 5dd9609)
let insertions = self.insertions.load(Ordering::Relaxed); | ||
let lost_insertions = self.insertions.load(Ordering::Relaxed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: #35191
Problem
Through multiple reworks of the loaded programs cache its statistics have become meaningless nonsense.
Summary of Changes
hits
,misses
reloads
,lost_insertions
prunes_expired