Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - LoadedPrograms statistics #35026

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Jan 31, 2024

Problem

Through multiple reworks of the loaded programs cache its statistics have become meaningless nonsense.

Summary of Changes

  • Fixes hits, misses
  • Adds reloads, lost_insertions
  • Removes prunes_expired

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b3ea62f) 81.6% compared to head (55160b3) 81.6%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35026     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         830      830             
  Lines      224828   224837      +9     
=========================================
- Hits       183521   183509     -12     
- Misses      41307    41328     +21     

@Lichtso Lichtso force-pushed the fix/loader_cache_stats branch 2 times, most recently from 1fd11d4 to 8513159 Compare February 1, 2024 15:26
Adds reloads, lost_insertions.
Removes prunes_expired.
@Lichtso Lichtso merged commit 5dd9609 into solana-labs:master Feb 2, 2024
35 checks passed
@Lichtso Lichtso deleted the fix/loader_cache_stats branch February 2, 2024 12:35
@Lichtso Lichtso added v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18 labels Feb 2, 2024
Copy link
Contributor

mergify bot commented Feb 2, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link
Contributor

mergify bot commented Feb 2, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 2, 2024
Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)

# Conflicts:
#	program-runtime/src/loaded_programs.rs
mergify bot pushed a commit that referenced this pull request Feb 2, 2024
Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)

# Conflicts:
#	program-runtime/src/loaded_programs.rs
Lichtso added a commit that referenced this pull request Feb 2, 2024
Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)
Lichtso added a commit that referenced this pull request Feb 2, 2024
Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)
Lichtso added a commit that referenced this pull request Feb 2, 2024
Fix - LoadedPrograms statistics (#35026)

Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Lichtso added a commit that referenced this pull request Feb 3, 2024
Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)
Lichtso added a commit that referenced this pull request Feb 5, 2024
Fix - LoadedPrograms statistics (#35026)

Fixes hits, misses.
Adds reloads, lost_insertions.
Removes prunes_expired.

(cherry picked from commit 5dd9609)

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
let insertions = self.insertions.load(Ordering::Relaxed);
let lost_insertions = self.insertions.load(Ordering::Relaxed);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: #35191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants