-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.17: Adds more info to panic message in AccountsHashVerifier (backport of #35353) #35358
Conversation
(cherry picked from commit 6aaaf85)
Justification for backporting: So far this issue has been difficult to debug, as it often depends on the state of the machine (and filesystem) when the panic occurs. Without this backport, then we are effectively saying that we are OK with v1.17 not aiding in debugging. And then likely we would not backport a fix either (because if we aren't willing to backport debug info, why would we suddenly be OK with a more invasive fix). |
Review requests:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #35358 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 806 806
Lines 218996 219092 +96
=========================================
+ Hits 178758 178831 +73
- Misses 40238 40261 +23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the BP; very narrow scope and will provide additional insight to debug a panic that we're seeing intermittently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for stable branch
@sakridge Can I get your review on this backport? |
This is an automatic backport of pull request #35353 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com