Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if sent a bad packet #369

Merged
merged 1 commit into from
Jun 16, 2018
Merged

Conversation

garious
Copy link
Contributor

@garious garious commented Jun 16, 2018

No description provided.

@garious garious requested a review from sakridge June 16, 2018 15:19
@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #369 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   90.98%   90.77%   -0.22%     
==========================================
  Files          36       36              
  Lines        3484     3490       +6     
==========================================
- Hits         3170     3168       -2     
- Misses        314      322       +8
Impacted Files Coverage Δ
src/ledger.rs 100% <100%> (ø) ⬆️
src/replicate_stage.rs 95.45% <100%> (ø) ⬆️
src/tvu.rs 97.81% <0%> (-1.46%) ⬇️
src/crdt.rs 84.2% <0%> (-1.16%) ⬇️
src/entry_writer.rs 88.57% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d84ec4...43f1643. Read the comment docs.

@garious garious merged commit f6e7077 into solana-labs:master Jun 16, 2018
willhickey pushed a commit to willhickey/solana that referenced this pull request Mar 23, 2024
…rts (backport of solana-labs#266) (solana-labs#369)

Cli stake-split: adjust transfer amount if recipient has lamports (solana-labs#266)

* Remove incorrect check

* Move to closure

* Use match statement instead

* Adjust rent_exempt_reserve by existing balance

* Only transfer lamports if rent_exempt_reserve needs are greater than 0

* Rename variable for clarity

* Add minimum-delegation check

* Bump test split amount to meet arbitrary mock minimum-delegation amount

(cherry picked from commit dff99d0)

# Conflicts:
#	cli/src/stake.rs

Co-authored-by: Tyera <tyera@anza.xyz>
willhickey pushed a commit that referenced this pull request Mar 23, 2024
…rts (backport of #266) (#369)

Cli stake-split: adjust transfer amount if recipient has lamports (#266)

* Remove incorrect check

* Move to closure

* Use match statement instead

* Adjust rent_exempt_reserve by existing balance

* Only transfer lamports if rent_exempt_reserve needs are greater than 0

* Rename variable for clarity

* Add minimum-delegation check

* Bump test split amount to meet arbitrary mock minimum-delegation amount

(cherry picked from commit dff99d0)

# Conflicts:
#	cli/src/stake.rs

Co-authored-by: Tyera <tyera@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant