Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort when -l is not present or unreadable #370

Merged
merged 1 commit into from
Jun 16, 2018
Merged

Conversation

mvines
Copy link
Member

@mvines mvines commented Jun 16, 2018

Fixes #367

@mvines mvines requested a review from garious June 16, 2018 16:39
@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #370 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   90.77%   91.06%   +0.28%     
==========================================
  Files          36       36              
  Lines        3490     3490              
==========================================
+ Hits         3168     3178      +10     
+ Misses        322      312      -10
Impacted Files Coverage Δ
src/crdt.rs 85.36% <0%> (+1.15%) ⬆️
src/tvu.rs 99.27% <0%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e7077...55b36e6. Read the comment docs.

@mvines mvines merged commit 92599ac into solana-labs:master Jun 16, 2018
@mvines mvines deleted the l branch July 8, 2018 03:10
CriesofCarrots pushed a commit that referenced this pull request Feb 28, 2020
mvines pushed a commit to mvines/solana that referenced this pull request Jun 15, 2020
mvines pushed a commit that referenced this pull request Jun 15, 2020
apfitzge referenced this pull request in apfitzge/agave Mar 21, 2024
* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
dnut pushed a commit to dnut/solana that referenced this pull request Mar 21, 2024
* Discard packets statically known to fail

* add test
willhickey pushed a commit to willhickey/solana that referenced this pull request Mar 23, 2024
…abs#370) (solana-labs#375)

* Discard packets statically known to fail (solana-labs#370)

* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

* resolve conflicts: old metrics update style

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
willhickey pushed a commit to willhickey/solana that referenced this pull request Mar 23, 2024
…abs#370) (solana-labs#374)

* Discard packets statically known to fail (solana-labs#370)

* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

* resolve conflict

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
willhickey pushed a commit that referenced this pull request Mar 23, 2024
)

* Discard packets statically known to fail (#370)

* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

* resolve conflicts: old metrics update style

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
willhickey pushed a commit that referenced this pull request Mar 23, 2024
)

* Discard packets statically known to fail (#370)

* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

* resolve conflict

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants