This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Initialize broadcaster to entry count #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the initialized count 0? |
|
in the multi_node tests, the count (both window and broadcaster) start at zero. In the multinode-demo/, with a 10,000 token mint, they both start at 16385. |
rob-solana
force-pushed
the
initialize-broadcaster-to-entry-count
branch
3 times, most recently
from
cc8bd1a to
82caadf
Compare
sakridge
approved these changes
Jun 27, 2018
garious
added
automerge
garious
approved these changes
Jun 27, 2018
|
💔 Unable to automerge due to CI failure |
1 similar comment
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
automerge
rob-solana
force-pushed
the
initialize-broadcaster-to-entry-count
branch
from
82caadf to
ea2229a
Compare
rob-solana
force-pushed
the
initialize-broadcaster-to-entry-count
branch
from
ea2229a to
2a82a1f
Compare
|
@rob-solana, you merged a PR with |
|
whoops, do you want me to attempt a fix, rewite history or just be more careful in the future? |
|
Be more careful in the future. And use |
|
ack |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oddly, this PR doesn't change observed behavior between multinode-demo nodes, nor does it appear to have any effect on Stephen's multinode validator catchup test #450 (which is included in this PR)