Don't clone before borrowing #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy told us to change function parameters to references, but wasn't able to then tell us that the clone() before borrowing was superfluous. This patch removes those by hand. No expectation of a performance improvement here, since we were just cloning reference counts. Just removes a bunch of noise.
|
@sakridge, still waiting on your review here. |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…labs#608) Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 0.80.0 to 0.80.1. - [Release notes](https://github.com/solana-labs/solana-web3.js/releases) - [Commits](solana-labs/solana-web3.js@v0.80.0...v0.80.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Apr 24, 2023
jeffwashington
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 5, 2024
Bump h2 (solana-labs#570) (cherry picked from commit f6e02e6) Co-authored-by: Tyera <tyera@anza.xyz>
willhickey
pushed a commit
that referenced
this pull request
Apr 8, 2024
HaoranYi
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Apr 8, 2024
Bump h2 (solana-labs#570) (cherry picked from commit f6e02e6) Co-authored-by: Tyera <tyera@anza.xyz>
HaoranYi
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Apr 8, 2024
Bump h2 (solana-labs#570) (cherry picked from commit f6e02e6) Co-authored-by: Tyera <tyera@anza.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy told us to change function parameters to references, but
wasn't able to then tell us that the clone() before borrowing
was superfluous. This patch removes those by hand.
No expectation of a performance improvement here, since we were
just cloning reference counts. Just removes a bunch of noise.