Accounts index updates, remove pubkey when dead account #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7408 +/- ##
========================================
+ Coverage 80.6% 80.6% +<.1%
========================================
Files 245 244 -1
Lines 48439 47778 -661
========================================
- Hits 39048 38548 -500
+ Misses 9391 9230 -161 |
ryoqun
reviewed
Dec 11, 2019
runtime/src/accounts_db.rs
Outdated
| for pubkey in purges.keys() { | ||
| reclaims.extend(accounts_index.purge(&pubkey)); | ||
| let purge = accounts_index.purge(&pubkey); |
There was a problem hiding this comment.
nits: I think .1 and .0 isn't readable... So how about this using destructring?
let mut all_reclaims = Vec::new();
for ...
let (reclaims, is_empty) = accounts_index...
all_reclaims.extend(reclaims);
if (is_empty) {
dead_keys.push(...
}There was a problem hiding this comment.
Yea. That's better. Thanks.
ryoqun
reviewed
Dec 11, 2019
ryoqun
requested changes
Dec 11, 2019
ryoqun
previously approved these changes
Dec 11, 2019
sakridge
force-pushed
the
remove-dead-accounts
branch
from
eee930e
to
d3e4d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts index never cleans up dead account keys, leaving a pubkey in the hash table pointing to a vec which will not be deallocated.
Summary of Changes
Detect when an account exists on no branches in purge zero lamport accounts and remove it from the index.
Fixes #