Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow coding shred index to be different than data shred index #7438

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Dec 11, 2019

Problem

First coding shred index must be same as the first data shred index in an FEC block. This prevents an FEC block to have more number of coding shreds than number of data shreds (as that'll cause the last coding shred index to overlap with the data shred index of the next FEC block).

Summary of Changes

Decoupled the coding shred index from data shred index. Also, updated erasure recovery code to use the new indexing scheme.

Reference #7428

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #7438 into master will decrease coverage by 11%.
The diff coverage is 52.7%.

@@            Coverage Diff            @@
##           master   #7438      +/-   ##
=========================================
- Coverage    75.9%   64.9%   -11.1%     
=========================================
  Files         244     245       +1     
  Lines       51675   60518    +8843     
=========================================
+ Hits        39243   39291      +48     
- Misses      12432   21227    +8795

Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but @carllin's review would be good too

@pgarg66
Copy link
Contributor Author

pgarg66 commented Dec 12, 2019

Added fec_set_index to shred common header so that data shreds can identify FEC set they belong to. This will be needed for solving #7450

@pgarg66 pgarg66 merged commit d94041e into solana-labs:master Dec 13, 2019
@pgarg66 pgarg66 deleted the issue7428 branch December 13, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants