Generate MAX_DATA_SHREDS_PER_FEC_BLOCK coding shreds for each FEC block #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-solana
approved these changes
Dec 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #7474 +/- ##
========================================
+ Coverage 73.1% 73.1% +<.1%
========================================
Files 244 244
Lines 53843 53851 +8
========================================
+ Hits 39389 39409 +20
+ Misses 14454 14442 -12 |
sagar-solana
added a commit
to sagar-solana/solana
that referenced
this pull request
Jan 21, 2020
… FEC block (solana-labs#7474)" This reverts commit 7adc721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FEC blocks with less number of data shreds do not contain enough coding shreds. The erasure recovery gets impacted due to this.
Summary of Changes
Generate MAX_DATA_SHREDS_PER_FEC_BLOCK coding shreds for each FEC block
Reference: #7428