Tame overeager wallet manager #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
previously approved these changes
Apr 2, 2020
|
@garious , do you need this in 1.0? |
|
No, just 1.1 |
Codecov Report
@@ Coverage Diff @@
## master #9262 +/- ##
========================================
- Coverage 81% 81% -0.1%
========================================
Files 276 276
Lines 61103 61103
========================================
- Hits 49511 49498 -13
- Misses 11592 11605 +13 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2020
* Add helper fn to check for usb cli args * Use helper fn to prevent wallet_manager connecting unnecessarily * Review improvements (cherry picked from commit ec4745d)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 2, 2020
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 18, 2020
This reverts commit ec4745d.
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 18, 2020
This reverts commit ec4745d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cli's wallet manager is indexing usb devices anytime it detects one, even if a command doesn't require a remote wallet. This is particularly problematic if a hardware wallet is connected but has timed out, because the cli may return a remote-wallet error instead of processing the command normally.
Summary of Changes
Add helper function to check for KeypairUrl::Usb args, and only initialize the wallet manager if one or more is present.
Fixes #8768