Consider config in check_for_usb (cli, keygen) #9555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
approved these changes
Apr 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #9555 +/- ##
========================================
- Coverage 80.7% 80.6% -0.1%
========================================
Files 279 279
Lines 63192 63192
========================================
- Hits 50998 50995 -3
- Misses 12194 12197 +3 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2020
(cherry picked from commit a9c38fb)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 17, 2020
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 18, 2020
This reverts commit a9c38fb.
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Apr 18, 2020
This reverts commit a9c38fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
check_for_usb()usage only looks at explicit arguments, effectively breaking the ability to set a remote wallet in config.ymlSummary of Changes
Check
config.keypair_pathvalue withcheck_for_usb()as part of maybe_wallet_manager decision