Fix hanging local cluster test: test_validator_exit_2 #9571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Local cluster tests hang in CI, on test
test_validator_exit_2
since #9560 . Test never sees active stake in gossip --get_stake_percent_in_gossip
no longer includes the current node, and local cluster never reaches this line https://github.com/solana-labs/solana/blob/master/local-cluster/src/local_cluster.rs#L272 -- so loops indefinitely.Summary of Changes
Remove
wait_for_majority
config setting@mvines , another solution would be to restore the
else if
case toget_stake_percent_in_gossip()
heresolana/core/src/validator.rs
Line 838 in f142451
But I assume that was a deliberate choice for the the 80% to not include the current node.