Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging local cluster test: test_validator_exit_2 #9571

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Apr 18, 2020

Problem

Local cluster tests hang in CI, on test test_validator_exit_2 since #9560 . Test never sees active stake in gossip -- get_stake_percent_in_gossip no longer includes the current node, and local cluster never reaches this line https://github.com/solana-labs/solana/blob/master/local-cluster/src/local_cluster.rs#L272 -- so loops indefinitely.

Summary of Changes

Remove wait_for_majority config setting

@mvines , another solution would be to restore the else if case to get_stake_percent_in_gossip() here

} else {
like:

} else if vote_state.node_pubkey == cluster_info.read().unwrap().id() {
            online_stake += activated_stake;
}

But I assume that was a deliberate choice for the the 80% to not include the current node.

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #9571 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #9571     +/-   ##
========================================
+ Coverage    80.4%   80.6%   +0.1%     
========================================
  Files         279     279             
  Lines       63409   63409             
========================================
+ Hits        51033   51109     +76     
+ Misses      12376   12300     -76     

@mvines
Copy link
Member

mvines commented Apr 18, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants