Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename JS wallet API to more closely match upcoming Kotlin API #107

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: rename JS wallet API to more closely match upcoming Kotlin API #107

merged 1 commit into from
Jul 13, 2022

Conversation

steveluscher
Copy link
Contributor

We're moving toward the API being:

transact(walletAPI => { /* ... */ });

…to leave open the future for an API like

transact.usingRemoteWallet(remoteConfig, walletAPI => { /* ... */ });

creativedrewy
creativedrewy approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@creativedrewy creativedrewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transact the planet!!!

@steveluscher steveluscher merged commit 28953b0 into main Jul 13, 2022
@steveluscher steveluscher deleted the rename-js-wallet-api branch July 13, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creativedrewy creativedrewy creativedrewy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveluscher @creativedrewy