Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FakeDApp offchain message signing should use non-random messages #407

Merged
merged 1 commit into from
Mar 9, 2023
Merged

FakeDApp offchain message signing should use non-random messages #407

merged 1 commit into from
Mar 9, 2023

Conversation

sdlaver
Copy link
Contributor

@sdlaver sdlaver commented Mar 9, 2023

This improves both repeatability of tests, as well as comprehension of signing in wallets

@sdlaver
FakeDApp offchain message signing should use non-random messages
a0bbf2b 
This improves both repeatability of tests, as well as comprehension of signing
in wallets
@sdlaver
Copy link
Contributor Author

sdlaver commented Mar 9, 2023

@nickcruz I'd propose this change instead of #233.

nickcruz
nickcruz approved these changes Mar 9, 2023
View reviewed changes
Copy link

@nickcruz nickcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup sounds good, I can close #233 then!

@sdlaver sdlaver mentioned this pull request Mar 9, 2023
Closed
@sdlaver sdlaver merged commit 6da00f9 into solana-mobile:main Mar 9, 2023
@sdlaver sdlaver deleted the sign-messages-fakedapp branch March 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickcruz nickcruz nickcruz approved these changes

@Funkatronics Funkatronics Awaiting requested review from Funkatronics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdlaver @nickcruz