Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RN walletlib build scripts #479

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

Michaelsulistio
Copy link
Contributor

@Michaelsulistio Michaelsulistio commented Jun 6, 2023

This PR refactors the scripts in the package.json of RN walletlib. Previously, the library was using the rollup.config.ts script to create esm/cjs for browser/node/react-native environments.

For this library, we only need to support react native environment.

Changes:

  • Added a dev dependency to https://github.com/callstack/react-native-builder-bob. This library provides convenient scripts to output a build lib for publishing.
  • Refactor the package.json to use react-native-builder-bob rather than the rollup config.
  • Add a README TODO list

@Michaelsulistio Michaelsulistio merged commit 92dd4c1 into main Jun 6, 2023
@Michaelsulistio Michaelsulistio deleted the refactor-walletlib-build branch June 6, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants