Expose Deauthorize Requests/Event to React Native #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelsulistio
approved these changes
Jul 21, 2023
| @@ -76,9 +77,10 @@ internal object MobileWalletAdapterResponseSerializer : JsonContentPolymorphicSe | |||
| override fun selectDeserializer(element: JsonElement): DeserializationStrategy<out MobileWalletAdapterResponse> = | |||
| if ((element as? JsonObject)?.containsKey("failReason") == true) FailReasonTransformingSerializer | |||
| else if ((element as? JsonObject)?.containsKey("publicKey") == true) AuthorizeDappResponse.serializer() | |||
There was a problem hiding this comment.
Ideally, we also include a __type in the response object, so instead of checking for unique fields we can just check a more readable __type field. Not a big deal/blocker though and probably not worth a whole refactor.
There was a problem hiding this comment.
yeah I actually started to add that but ran into some issues on the JS side due to the use of types vs classes. I couldn't find a clean way to enforce the __type field so it was getting omitted if I did not explicitly add it to every response, which seemed like a highly error prone situation if we are relying on those types for deserialization. Obviously there has to be a better way to handle this but decided to leave it out for a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.