Make terminal themes match Xresources #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Light and dark colors copied from the .Xresources configuration. This results in the solarized vim theme (when run in xfce4-terminal) matching the gvim theme.
|
Here's a screenshot of htop for comparison. |
|
@bsidhom - Apologies for the late reply on this. If you can retarget this pull request to my repository, I'd be happy to merge it and assist in getting this repository updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have copied the color scheme directly from the .Xresources configuration.
This results in the solarized vim theme (when run in xfce4-terminal) matching
the gvim theme.
When I use the old dark xfce4 color scheme with a light background in vim, quoted strings become nearly impossible to see (as they use a nearly white foreground). The new version results in legible coloring with all four (xfce4, vim) background settings.