Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to SWIS REST endpoint #333

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Changes to SWIS REST endpoint #333

merged 2 commits into from
Mar 31, 2023

Conversation

petr-jancik-swi
Copy link
Contributor

Change HTTPS endpoint port
Add HTTPS endpoint for legacy SWIS REST endpoint
Keep curl query export to clipboard for new and legacy port

@petr-jancik-swi
Change HTTPS endpoint port
f556099 
Add HTTPS endpoint for legacy SWIS REST endpoint
Keep curl query export to clipboard for new and legacy port
danjagnow
danjagnow approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@danjagnow danjagnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For reference, see SolarWinds Port Requirements and SWIS REST API Port Deprecation, did you know?

Src/SwqlStudio/MainForm.resx Outdated Show resolved Hide resolved
@petr-jancik-swi petr-jancik-swi marked this pull request as ready for review March 13, 2023 08:40
@kmsigma
Copy link
Contributor

kmsigma commented Mar 29, 2023

Confirmed after compilation that the new ports are reflecting correctly in the "Copy As" fields

Legacy curl (cmd)
curl.exe -k -u MyUsername:MyC0mpl3xP@ssw0rd https://192.168.21.217:17778/SolarWinds/InformationService/v3/Json/Query?query=SELECT+TOP+1+ExecutedAt%2c+EndpointServiceID%2c+ProbeID%2c+ProbeStatus%2c+CompletionRatio%2c+UniqueEdgeCount%2c+UniquePathCount%2c+TotalTraceCount%2c+TotalEdgeCount%2c+PortClosedTraceCount%2c+DestUnreachedTraceCount%2c+DnsFailureTraceCount%2c+RouteChangeCount%2c+EdgeChangeCount%2c+SentPackets%2c+LostPackets%2c+ConnectionBased%2c+Rtt%2c+RttMin%2c+PacketLoss%2c+Status%2c+DisplayName%2c+Description%2c+InstanceType%2c+Uri%2c+InstanceSiteId%2c+SentPackets+-+LostPackets+AS+%5bPayload%5d+FROM+Orion.NetPath.Tests+WHERE+EndpointServiceId+%3d+9+AND+ProbeId+%3d+1+AND+ExecutedAt+%3e%3d+GETUTCDATE()+-+1+AND+Length(Graph)%3e0+ORDER+BY+ExecutedAt+DESC

Legacy curl (bash)
curl -k -u MyUsername:MyC0mpl3xP@ssw0rd https://192.168.21.217:17778/SolarWinds/InformationService/v3/Json/Query?query=SELECT+TOP+1+ExecutedAt%2c+EndpointServiceID%2c+ProbeID%2c+ProbeStatus%2c+CompletionRatio%2c+UniqueEdgeCount%2c+UniquePathCount%2c+TotalTraceCount%2c+TotalEdgeCount%2c+PortClosedTraceCount%2c+DestUnreachedTraceCount%2c+DnsFailureTraceCount%2c+RouteChangeCount%2c+EdgeChangeCount%2c+SentPackets%2c+LostPackets%2c+ConnectionBased%2c+Rtt%2c+RttMin%2c+PacketLoss%2c+Status%2c+DisplayName%2c+Description%2c+InstanceType%2c+Uri%2c+InstanceSiteId%2c+SentPackets+-+LostPackets+AS+%5bPayload%5d+FROM+Orion.NetPath.Tests+WHERE+EndpointServiceId+%3d+9+AND+ProbeId+%3d+1+AND+ExecutedAt+%3e%3d+GETUTCDATE()+-+1+AND+Length(Graph)%3e0+ORDER+BY+ExecutedAt+DESC

Current curl (cmd)
curl.exe -k -u MyUsername:MyC0mpl3xP@ssw0rd https://192.168.21.217:17774/SolarWinds/InformationService/v3/Json/Query?query=SELECT+TOP+1+ExecutedAt%2c+EndpointServiceID%2c+ProbeID%2c+ProbeStatus%2c+CompletionRatio%2c+UniqueEdgeCount%2c+UniquePathCount%2c+TotalTraceCount%2c+TotalEdgeCount%2c+PortClosedTraceCount%2c+DestUnreachedTraceCount%2c+DnsFailureTraceCount%2c+RouteChangeCount%2c+EdgeChangeCount%2c+SentPackets%2c+LostPackets%2c+ConnectionBased%2c+Rtt%2c+RttMin%2c+PacketLoss%2c+Status%2c+DisplayName%2c+Description%2c+InstanceType%2c+Uri%2c+InstanceSiteId%2c+SentPackets+-+LostPackets+AS+%5bPayload%5d+FROM+Orion.NetPath.Tests+WHERE+EndpointServiceId+%3d+9+AND+ProbeId+%3d+1+AND+ExecutedAt+%3e%3d+GETUTCDATE()+-+1+AND+Length(Graph)%3e0+ORDER+BY+ExecutedAt+DESC

Current curl (bash)
curl -k -u MyUsername:MyC0mpl3xP@ssw0rd https://192.168.21.217:17774/SolarWinds/InformationService/v3/Json/Query?query=SELECT+TOP+1+ExecutedAt%2c+EndpointServiceID%2c+ProbeID%2c+ProbeStatus%2c+CompletionRatio%2c+UniqueEdgeCount%2c+UniquePathCount%2c+TotalTraceCount%2c+TotalEdgeCount%2c+PortClosedTraceCount%2c+DestUnreachedTraceCount%2c+DnsFailureTraceCount%2c+RouteChangeCount%2c+EdgeChangeCount%2c+SentPackets%2c+LostPackets%2c+ConnectionBased%2c+Rtt%2c+RttMin%2c+PacketLoss%2c+Status%2c+DisplayName%2c+Description%2c+InstanceType%2c+Uri%2c+InstanceSiteId%2c+SentPackets+-+LostPackets+AS+%5bPayload%5d+FROM+Orion.NetPath.Tests+WHERE+EndpointServiceId+%3d+9+AND+ProbeId+%3d+1+AND+ExecutedAt+%3e%3d+GETUTCDATE()+-+1+AND+Length(Graph)%3e0+ORDER+BY+ExecutedAt+DESC

@danjagnow danjagnow merged commit 14a18a2 into solarwinds:master Mar 31, 2023
petr-jancik-swi added a commit to petr-jancik-swi/orionsdk-python that referenced this pull request Apr 4, 2023
@petr-jancik-swi
change client REST port to 17774
f90c6e2 
adjust SolarWinds class to be able to override port

for changes to main OrionSDK and rationale behind the change see
solarwinds/OrionSDK#333 (review)
@petr-jancik-swi petr-jancik-swi mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjagnow danjagnow danjagnow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petr-jancik-swi @kmsigma @danjagnow