Merge pull request #139 from appoptics/ao-18716-fix-node14-warning

AO-18716 fix node 14 non-existent property warning
solarwinds · Feb 11, 2021 · 051453a · 051453a
2 parents 2a8e528 + 18c4255
commit 051453a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/api-sim.js b/lib/api-sim.js
@@ -7,7 +7,11 @@ let cls;
 module.exports = function (appoptics) {
   ao = appoptics;
   aob = ao.addon;
-  cls = ao.cls;
+  // check for property to avoid triggering node 14 warning on
+  // non-existent property in unfinished module.exports
+  if (ao.hasOwnProperty('cls')) {
+    cls = ao.cls;
+  }
 
   // define the properties (some of which are part of the API)
   definePropertiesOn(ao);
@@ -760,4 +764,3 @@ function insertLogObject (o = {}) {
 function wrapLambdaHandler (fn) {
   return fn;
 }
-
diff --git a/lib/api.js b/lib/api.js
@@ -34,7 +34,9 @@ module.exports = function (appoptics) {
   ao.maps.responseFinalizers = responseFinalizers;
 
   // each invocation in lambda is counted
-  if (ao.lambda) {
+  // use property check that does not trigger node 14 warning on
+  // non-existent property in unfinished module.exports
+  if (ao.hasOwnProperty('lambda')) {
     ao.lambda.invocations = 0;
   }