Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-Main #198

Draft
wants to merge 179 commits into
base: master
Choose a base branch
from
Draft

NH-Main #198

wants to merge 179 commits into from

Conversation

ronilan
Copy link
Contributor

@ronilan ronilan commented Dec 2, 2021

*** DRAFT *** FOR REVIEW ONLY *** DO NOT MERGE *** DRAFT ***

Overview

This pull request provides the following features:

  1. Adds W3C Trace Context functionality using liboboe 10.3.x+ in mode 1.
  2. Adds Trace Context in Logs that match the Open Telemetry Specification.
  3. Adds Trace Context in Queries (SQL/CQL) to allow integration with SolarWinds DPM using Query Tags.
  4. Adds auto instrumentation of Node's native DNS module.
  5. Adds auto instrumentation to the promise interface of Node's native fs module.
  6. Adds auto instrumentation log4js package.

It upgrades the following features:

  1. Upgrades tedious (MS SQL) probe to support latest.
  2. Upgrades pino logging probe to support latest.

It modifies the following:

  1. Refactors the logging probes API simplifying both api methods and configuration settings.
  2. Refactors the morgan probe simplifying implementation and improving functionality.
  3. Changes naming of headers and reported KV pairs for Trigger Trace requests.
  4. Updates http/s probe KV pairs.
  5. Improves SQL Sanitization moving it form Bindings to Agent.

It implements the following:

  1. Removes array-flatten from dependencies.
  2. Removes methods from dependencies.
  3. Removes minimist from dependencies.
  4. Removes glob from dependencies.
  5. Removes cls-hooked from dependencies.
  6. Replaces debug-custom with debug dependency.
  7. Gracefully Disable Lambda Functionality until issues are resolved and code refactored.
  8. Removes bin functionality which was outdated and undocumented.
  9. Removes deprecated environment variables.
  10. Removes the code used to detect and potentially handle conflicts with newrelic, strong-agent and appdynamics and also removes the ignoreConfilicts config setting.
  11. Removes disabled notifier "dead code". Notifier was added in add notifications,  #116 and disabled in: 1334a21. It has not been dealt since and is off the road map.
  12. Removes semver Conditionals for Outdated Node-Versions. If it is not a supported version, behavior is expected to be unexpected.
  13. Removes debug code. Do not ship debug code...
  14. Removes support for node versions 10 and 12. Supported versions are now 14, 16 and 18.
  15. Removes support from old versions of hapi and vision packages.
  16. Removes support for pg package versions under 7.
  17. Removes support for amqp package. Package has not been updated in 4 years. Not actively tested. has alternative.

It fixes the following:

  1. Completely removes support node-cassandra-cql package.
  2. Fix False warning of main file loaded before agent
  3. Fix the q probe
  4. Resolve circular dependencies
  5. Always masks the Service Key

Notes:

@ronilan ronilan force-pushed the nh-main branch 3 times, most recently from 298ba9f to 7b4d717 Compare December 15, 2021 22:59
@ronilan ronilan force-pushed the nh-main branch 3 times, most recently from fc48dfc to cb70705 Compare January 20, 2022 05:11
@ronilan ronilan marked this pull request as draft February 8, 2022 23:37
@ronilan ronilan force-pushed the nh-main branch 7 times, most recently from da7e2d5 to b2c207e Compare February 25, 2022 02:19
@ronilan ronilan force-pushed the nh-main branch 2 times, most recently from 12a6283 to 83c4d0f Compare March 30, 2022 15:03
@ronilan ronilan force-pushed the nh-main branch 10 times, most recently from 27b64f0 to 255d213 Compare April 14, 2022 05:22
ronilan and others added 29 commits June 13, 2022 16:08
…ge warning condition to show in any other than development.
…nfig settings. Tests disabled and dev dependency removed years ago.
…vDependencies-5

NH-5414-Update-Dependencies-devDependencies-5 (cls-hooked)
…e-cassandra-cql-Probe

NH-14791-Completely-Remove-node-cassandra-cql-Probe
…e-Loaded-Before-Agent

NH-14790-Fix-False-Warning-File-Loaded-Before-Agent
…bsocket.org-in-Tests

Revert "NH-14040-Replace-websocket.org-in-Tests"
…nded on the actively maintained debug package.
…vDependencies-6

NH-5414-Update-Dependencies-devDependencies-6 (debug-custom)
…stead of compering and object instanceof in conditionals, now using the self evident properties of the evaluated object.
… the specific modules needed (loggers, probe-defaults).
…ndencies

NH-13380-Resolve-Circular-Dependencies
…nt (i.e. it is used under an http request). Cleaned test comments. All pass.
…uration-Options

NH-12822-Document-Probe-Configuration-Options
… otherSQL probes. Refactored and simplified test setup. and tests. Added SQL Trace Context injection.
…ys correctly when arguments include objects.
…vDependencies-6

NH-5414-Update-Dependencies-devDependencies-6 (debug-custom) (fix)
…error even if the input value itself is not a valid service key to avoid potential full or partial token leak.
…ey-when-Invalid

NH-16920-Mask-Logged-Service-Key-when-Invalid
…NS-fix

NH-8430-Auto-Instrument-Node-DNS (fix)
…es-Cassandra

NH-5772-Trace-Context-in-Queries (Cassandra)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant