Adds support for RedHat OpenShift clusters #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslav-fedor-swi
changed the title
jaroslav-fedor-swi
changed the title
jaroslav-fedor-swi
changed the title
| @@ -31,11 +31,20 @@ spec: | |||
| spec: | |||
| terminationGracePeriodSeconds: {{ .Values.otel.node_collector.terminationGracePeriodSeconds }} | |||
| serviceAccountName: {{ include "common.fullname" . }} | |||
| hostNetwork: true | |||
There was a problem hiding this comment.
Do we need to be on host metric everywhere or only on openshift?
There was a problem hiding this comment.
this is due to INFRA nodes, we can make it conditional only for openshift.
There was a problem hiding this comment.
Why do we need to mount node collector to host network interface? Even in openShift?
There was a problem hiding this comment.
hostNetwork option solves issues with access to journal logs and wr access to checkpoints folder. We decided that as first draft we go out with this not optimal solution and in operator we will deal with it properly.
gantrior
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our collector should be able to run on openshift cluster.
Limitations: