Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extracted Discovery Client from the Subscription Client #162

Merged
merged 6 commits into from
Mar 9, 2023
Merged

extracted Discovery Client from the Subscription Client #162

merged 6 commits into from
Mar 9, 2023

Conversation

elf-pavlik
Copy link
Member

@elf-pavlik elf-pavlik commented Mar 2, 2023 •
edited
Loading

TallTed
TallTed suggested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar fixes.

protocol.html Outdated Show resolved Hide resolved
elf-pavlik and others added 4 commits March 3, 2023 12:41
@elf-pavlik @TallTed
Update protocol.html
7a0377c 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@CxRes
Moved subscription text in Overview before diagram
60dc221 
Moved text in the Overview section describing the subscription process after the discovery diagram and before the subscription diagram.
@CxRes
Minor typo from previous edit of Overview
9703c74 
Replaced "diagrams" with "diagram" in Overview section.
@CxRes
Moved Resource Server to top of Product Classes
d20ab92 
Moved "Resource Server" to top of Classes of Products for a more natural ordering.
@CxRes CxRes requested a review from TallTed March 5, 2023 19:30
TallTed
TallTed suggested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things...

protocol.html Outdated Show resolved Hide resolved
protocol.html Show resolved Hide resolved
@elf-pavlik elf-pavlik mentioned this pull request Mar 9, 2023
Closed
@elf-pavlik @TallTed
Apply suggestions from code review
f7e16ca 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
csarven
csarven approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave out changes that are not pertinent to this PR for issues or other PRs, e.g., reordering classes of products :)

@csarven csarven merged commit 63c82e2 into solid:main Mar 9, 2023
@elf-pavlik elf-pavlik deleted the discovery-client branch March 9, 2023 16:34
@csarven csarven added this to the 0.3 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@csarven csarven csarven approved these changes

@CxRes CxRes Awaiting requested review from CxRes

@jaxoncreed jaxoncreed Awaiting requested review from jaxoncreed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@elf-pavlik @csarven @TallTed @CxRes