-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Editor’s Draft of the WAC specification #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much work went into that, it's a really nice read, thank you @csarven!
I hope a few of my comments make sense and we can discuss before merging, but regardless of their resolution, I would echo the others that this is a very big step in the right direction and I'm happy to see this on main
very soon! :)
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
This PR is already SO HUGE, it seems long past time to close the door to further review on this PR, merge it, and perform any further review against the |
Of course, I've followed on my suggestion to stop accepting suggestions with another suggestion.... |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
I think the only point worth addressing remaining in my review is the one about resources without conforming authorization: #83 (comment) The rest of my points relate to consistent Access Control Resource discovery and I'll try to phrase a relevant issue in this repo shortly. |
Thanks everyone for the reviews, feedback, emojis, etc. Merging the PR with no objections. Will follow up on issues/discussions. Let's take a moment to congrats each other (in our minds) for getting the WAC spec to this point. So there we have it. It is all sort of simple. |
After processing an ocean of documentation, issues, meetings,.. with the goal of coming up with an accurate representation of the WAC specification, this PR includes the initial Editor’s Draft (ED).
Merging this PR will replace the documentation in the README (but move its content to README-v.0.5.0), follow-up on close/respond to all applicable issues, and use the ED as the reference point.
Feedback on errors, inaccuracies, clarifications are welcome. Any request to change features or add extensions to WAC should be followed up in new or existing issues.
After the merge, the Solid Protocol will be updated to remove/update all information related to WAC. A ~Working Draft (WD) PR to the solid/specification repository will follow.
Issues/Discussions referenced:
acl:default
does not implyacl:accessTo
specification#193Edit: Includes response to solid/specification#147 and https://github.com/solid/specification/blob/main/CONTRIBUTING.md#publication-rules