Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deno support for solid cli #57

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Oct 31, 2024

Deno now supports process.env.npm_config_user_agent

Making it possible to add the deno installer to this project, so we can make this green

Screenshot 2024-11-01 at 19 56 46

@birkskyum
Copy link
Contributor Author

birkskyum commented Nov 1, 2024

@Tommypop2 It's working now, it's possible to create and run a project.

solid-cli on  add-deno-option-for-cli [!?] via ⬢ v22.11.0 via 🅒 base 
➜ deno task deno
Task deno deno run --unstable-bare-node-builtins -A ./packages/create-solid/src/index.ts
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:324. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "path" as "node:path" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:372. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs" as "node:fs" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:475. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:256. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "os" as "node:os" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:306. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "path" as "node:path" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:375. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "util" as "node:util" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:5:158. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/fs/index.mjs:1:26. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/updates/index.mjs:1:37. If you want to use a built-in Node module, add a "node:" prefix.
┌  
 Create-Solid v0.5.13
│
◇  Project Name
│  new-solid-project
│
◇  Is this a SolidStart project?
│  Yes
│
◇  Which template would you like to use?
│  basic
│
◇  Use Typescript?
│  Yes
│
◇  Project successfully created! 🎉
│
◇  To get started, run: ─╮
│                        │
│  cd new-solid-project  │
│  deno install          │
│  deno task dev         │
│                        │
├────────────────────────╯


solid-cli on  add-deno-option-for-cli [!?] via ⬢ v22.11.0 via 🅒 base took 11.3s 
➜ cd new-solid-project

solid-cli/new-solid-project on  add-deno-option-for-cli [!?] via ⬢ v22.11.0 via 🅒 base 
➜ deno install 
Warning The following packages are deprecated:
┠─ npm:shikiji@0.9.19 (Shikiji is merged back to Shiki v1.0, please migrate over to get the latest updates)
┠─ npm:shikiji-core@0.9.19 (Shikiji is merged back to Shiki v1.0, please migrate over to get the latest updates)
┠─ npm:glob@8.1.0 (Glob versions prior to v9 are no longer supported)
┠─ npm:glob@7.2.3 (Glob versions prior to v9 are no longer supported)
┠─ npm:inflight@1.0.6 (This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.)
┠─ npm:npmlog@5.0.1 (This package is no longer supported.)
┠─ npm:rimraf@3.0.2 (Rimraf versions prior to v4 are no longer supported)
┠─ npm:are-we-there-yet@2.0.0 (This package is no longer supported.)
┖─ npm:gauge@3.0.2 (This package is no longer supported.)

solid-cli/new-solid-project on  add-deno-option-for-cli [!?] via ⬢ v22.11.0 via 🅒 base 
➜  deno task dev
Task dev vinxi dev
vinxi v0.4.3
vinxi starting dev server

  ➜ Local:    http://localhost:3000/
  ➜ Network:  use --host to expose

7:46:22 PM [vite] page reload vinxi/routes
7:46:22 PM [vite] page reload vinxi/routes (x2)
7:46:22 PM [vite] page reload vinxi/routes (x3)

@birkskyum birkskyum marked this pull request as ready for review November 1, 2024 18:47
@Tommypop2
Copy link
Member

Looks great, thanks!

@Tommypop2 Tommypop2 merged commit b516a0e into solidjs-community:main Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants