-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update middleware docs #1010
Merged
LadyBluenotes
merged 64 commits into
solidjs:main
from
amirhhashemi:update-middleware-docs
Feb 18, 2025
Merged
Update middleware docs #1010
LadyBluenotes
merged 64 commits into
solidjs:main
from
amirhhashemi:update-middleware-docs
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
devagrawal09
reviewed
Jan 9, 2025
Overall I think this adds a lot of good information to the middleware docs |
LadyBluenotes
requested changes
Jan 28, 2025
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
LadyBluenotes
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
This PR adds comprehensive documentation for middleware. Please refer to this Discord thread for additional background and discussion regarding this PR.
It follows the explanation guide from the Diátaxis framework, as this fits better with the other related pages. I focused on the theoretical aspects of middleware and avoided too much practical detail to reduce overlap with reference and guide pages.
Related issues & labels