Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middleware docs #1010

Merged
merged 64 commits into from
Feb 18, 2025
Merged

Conversation

amirhhashemi
Copy link
Collaborator

@amirhhashemi amirhhashemi commented Jan 9, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR adds comprehensive documentation for middleware. Please refer to this Discord thread for additional background and discussion regarding this PR.

It follows the explanation guide from the Diátaxis framework, as this fits better with the other related pages. I focused on the theoretical aspects of middleware and avoided too much practical detail to reduce overlap with reference and guide pages.

Related issues & labels

Copy link

stackblitz bot commented Jan 9, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit de132c0
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67b3d6756ed0e200080abf6e
😎 Deploy Preview https://deploy-preview-1010--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes added the in progress Someone is currently working on the issue. label Jan 10, 2025
@amirhhashemi amirhhashemi marked this pull request as ready for review January 19, 2025 08:42
@amirhhashemi amirhhashemi marked this pull request as draft January 20, 2025 15:20
@brenelz
Copy link
Collaborator

brenelz commented Jan 24, 2025

Overall I think this adds a lot of good information to the middleware docs

@amirhhashemi amirhhashemi marked this pull request as ready for review January 25, 2025 08:52
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
src/routes/solid-start/advanced/middleware.mdx Outdated Show resolved Hide resolved
amirhhashemi and others added 27 commits January 31, 2025 17:28
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
@LadyBluenotes LadyBluenotes enabled auto-merge (squash) February 18, 2025 00:38
@LadyBluenotes LadyBluenotes merged commit d826971 into solidjs:main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Someone is currently working on the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]: The middleware page says that you can chain middleware but does not show how.
4 participants