Initial typings fs-router folder #709
Conversation
| @@ -1,7 +1,21 @@ | |||
| export default function fileRoutesImport({ types: t }) { | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Otherwise it'll say:
Cannot find module '@babel/types/lib' or its corresponding type declarations.ts(2307)
There was a problem hiding this comment.
Doesn't @types/babel__types have the types? I think by installing this package and importing things from @babe/types the issue would be resolved.
There was a problem hiding this comment.
I'll have another look at this
I guess it makes sense to ignore the errors using |
|
This code runs in node.. unfortunately which means it chokes on ts trying to do local builds as it doesn't get transformed and ends up breaking stuff. I have no clue how tests are passing but I think I will need to revert this unfortunately for now. |
This reverts commit 1890f44.
* type path-utils * convert fileRoutesImport to ts * add @types/babel-types * add types to fileRoutesImport * use @babel/types directly * add @babel/types as dependency * convert manifest to ts * add some types to manifest * rename router.js to .ts * convert router.js to .ts * Revert "rename router.js to .ts" This reverts commit 38049e1. * Revert "add some types to manifest" This reverts commit 9e44f91. * Revert "convert manifest to ts" This reverts commit 23ce4a3. * ts-ignore @babel/types * revert router.js --------- Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
It's hard to dive in and debug the FileRouter ( #707 ), because the fs-router folder doesn't have types.
This PR converts some of the fs-router files to typescript, without breaking the tests, and adds some types as a starting point.
The "typecheck" on the start package is a bit problematic, and should maybe be temporarily disabled, as it make a gradual migration to typescript very hard - because it will break until a file is 100% typed. I did partial typings of a few more files and had to revert it to .js to make the typecheck pass.