Reordering setter overloads (#2333)

* continue * add changeset --------- Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
solidjs · Oct 8, 2024 · bb6ce8b · bb6ce8b
1 parent 5c52b56
commit bb6ce8b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/empty-cars-jog.md b/.changeset/empty-cars-jog.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+Reordering setter overloads
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -179,12 +179,12 @@ export function createRoot<T>(fn: RootFunction<T>, detachedOwner?: typeof Owner)
 export type Accessor<T> = () => T;
 
 export type Setter<in out T> = {
-  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
   <U extends T>(
     ...args: undefined extends T ? [] : [value: Exclude<U, Function> | ((prev: T) => U)]
   ): undefined extends T ? undefined : U;
   <U extends T>(value: (prev: T) => U): U;
   <U extends T>(value: Exclude<U, Function>): U;
+  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
 };
 
 export type Signal<T> = [get: Accessor<T>, set: Setter<T>];