App + Subscription Metadata Editing, and User creation on login #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
… for admins + non-admins. Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Charlesthebird
changed the title
Worfle
reviewed
Sep 27, 2024
| if (shallowEquals(newRateLimitInfo, initialRateLimitInfo)) { | ||
| return; | ||
| } | ||
| (async () => { |
There was a problem hiding this comment.
Small nit that this section has a LOT of repeat that could be done as like toastObject(verb: string, metadataType:string) or whatever
There was a problem hiding this comment.
Agreed - I can do that refactor in a follow up.
| @@ -167,3 +167,19 @@ export const useInArea = (paths: string[]) => { | |||
| }); | |||
| }, [routerLocation.pathname, paths]); | |||
| }; | |||
|
|
|||
| export const shallowEquals = ( | |||
There was a problem hiding this comment.
Is this not out of the box in JS yet?
Worfle
reviewed
Sep 27, 2024
| @@ -167,3 +167,19 @@ export const useInArea = (paths: string[]) => { | |||
| }); | |||
| }, [routerLocation.pathname, paths]); | |||
| }; | |||
|
|
|||
| export const shallowEquals = ( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
This video shows the new login flow. I log in as the
admin_user. This user does not have a record in the portal server DB, so the website sends a request to create the user and mutates the SWR key for/me. The user info is then displayed correctly on the website.Screen.Recording.2024-09-25.at.4.27.32.PM.mov
This is a video of editing the rate limit and custom metadata as an admin user:
Screen.Recording.2024-09-27.at.2.41.02.PM.mov
Non admin users see this apps page and app details page view of the metadata.
There is a portal server bug with the subscriptions not returning the metadata, so when that is completed the metadata editor should work on the subscriptions as well, since it uses the same logic.