UI Hotfixes + Tweaks #106
Merged
UI Hotfixes + Tweaks #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific types on units
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
|
Issues linked to changelog: |
Comment on lines
+195
to
+199
| onChange={(value: RateLimitUnit | null) => { | ||
| if (!!value) { | ||
| setUnit(value); | ||
| } | ||
| }} |
There was a problem hiding this comment.
This was mostly a readability change. In the UI codebase (both here and GME), we try to be explicit when checking variable truthiness by converting it to a boolean first, like this (!!value is the same as Boolean(value)).
Charlesthebird
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Nick, validated on gg portal
mainbranch build following the instructions to kill4000and run themake uicommand.need to verify creating new subscription doesn't break ui when no rate limit is set (that UNKNOWN works as expected)
Screen.Recording.2024-10-21.at.3.05.36.PM.mov
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7038