Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination and storybook updates #89

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Pagination and storybook updates #89

merged 3 commits into from
Jul 17, 2024

Conversation

Charlesthebird
Copy link
Collaborator

@Charlesthebird Charlesthebird commented Jul 16, 2024 •
edited
Loading

This PR:

  • Includes a rewrite of the pagination code to include a page size selection dropdown.
  • Adds pagination to the GG + GMG API's pages.
  • Adds storybook stories for the pages where pagination is used.
    • The stories are categorized in the GG (Gloo Gateway) or GMG (Gloo Mesh Gateway) Storybook folders.
    • The image URL's for the API's come from pexels.com, which is a free stock photo website that does not require attribution.
Screenshot 2024-07-16 at 2 26 39 PM Screenshot 2024-07-16 at 2 26 13 PM Screenshot 2024-07-16 at 2 27 01 PM

Resolves: https://github.com/solo-io/gloo-mesh-enterprise/issues/17763

@Charlesthebird
updated pagination to include page size options, and added stories fo…
b04a1be 
…r where it was used.

Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
@Charlesthebird
comment
429402e 
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
@Charlesthebird Charlesthebird changed the title updated pagination to include page size options, and added stories fo… Pagination and storybook updates Jul 16, 2024
@Charlesthebird Charlesthebird marked this pull request as ready for review July 17, 2024 13:29
@Charlesthebird Charlesthebird marked this pull request as draft July 17, 2024 15:22
Worfle
Worfle reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Worfle Worfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for consistent pagination. Agree with Torey's comment on the more globalized constant

@Charlesthebird
page options now are variablized, and sorting is re-enabled.
91007d1 
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
@Charlesthebird Charlesthebird marked this pull request as ready for review July 17, 2024 15:59
@Charlesthebird Charlesthebird merged commit c702ed2 into main Jul 17, 2024
2 checks passed
@Charlesthebird Charlesthebird deleted the charlesthebird/apisPageClientPagination branch September 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toreysoloio toreysoloio toreysoloio approved these changes

@Worfle Worfle Awaiting requested review from Worfle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Charlesthebird @Worfle @toreysoloio