Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back in existing teams, apps, and admin portal server features #96

Merged

Conversation

Charlesthebird
Copy link
Collaborator

@Charlesthebird Charlesthebird commented Sep 5, 2024

Summary

This PR resolves the "Existing Features" section of the epic for supporting a GG portal server v1.18 backend.

These are features that existed from the GMG Teams + Apps feature branch. Since the Portal Server API in GG v1.18 is mostly the same as that feature branch, we can re-use and enable the UI code for these features now. These were the original designs for those pages.

Here are demo videos of the different re-enabled features.

Pt 1: API's and API Details pages:

Screen.Recording.2024-09-05.at.11.32.01.AM.mov

Pt 2: Teams, Team Details, App Details, Apps pages:

Screen.Recording.2024-09-05.at.11.33.09.AM.mov

Pt 3: Deleting subscription:

Screen.Recording.2024-09-05.at.11.34.49.AM.mov

Pt 4: Admin features (teams, apps, and subscription management):

Screen.Recording.2024-09-05.at.11.51.38.AM.mov

Environment Setup

Feel free to go off the videos + code, as the features being added have been mostly reviewed already. Adding in repro steps here though if there is interest.

  • Clone the solo-projects repo.
  • Run: sh hack/gateway-portal/reproduction/init.sh to partially set up your environment
  • Copy the USER_TOKEN=... line that is output around the last lines of the script, and execute that in your terminal.
  • Run the following to create the user in the Portal Server DB: curl http://developer.petstore.com:8080/v1/me -X "PUT" -H "Authorization: Bearer $USER_TOKEN"
  • Open Keycloak at localhost:8088, log in with username=admin password=admin.
    • Toggle "Confidential" to false on the "Clients" -> "ext-auth-server-client" page.
    • Add "http://localhost:4000/*" under "Valid post logout redirect URIs"
    • Check the "Standard Flow" checkbox
    • Hit "Save"
    • Logout from the keycloak UI.
  • In this project, run make run-ui (node version v18.16.0)
  • Open localhost:4000, and then log in with username=user1 password=pass

This process will be made easier in the future (noted in the epic issue), so that you will eventually just need to run the solo-projects script and then the UI.

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6808
resolves https://github.com/solo-io/solo-projects/issues/6809
resolves https://github.com/solo-io/solo-projects/issues/6810
resolves https://github.com/solo-io/solo-projects/issues/6811
resolves https://github.com/solo-io/solo-projects/issues/6812
resolves https://github.com/solo-io/solo-projects/issues/6813
resolves https://github.com/solo-io/solo-projects/issues/6814

Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6808

Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
@Charlesthebird
Copy link
Collaborator Author

This is being merged into the gg-portal-1.18-features branch, which should work with the portal-server backend in v1.18 of the solo-projects repo.

@Charlesthebird Charlesthebird marked this pull request as ready for review September 5, 2024 15:57
Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Copy link
Contributor

@Worfle Worfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot what the UX is for this app looks like. Those button after-effects :/

Code changes look fine

@Worfle Worfle merged commit b0ad09a into gg-portal-1.18-features Sep 5, 2024
2 checks passed
@Charlesthebird Charlesthebird deleted the charlesthebird/existing-1-18-features branch September 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants