Small DX improvements for entityTransformation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- export API and ApiVersion types to be reachable to client application when used in entityTransformation - update README and index.ts example with examples that has type checking and don't use any - update example to not use param reassigning - it might lead to unwanted side-effects inside the library due to reference change and is usually not a good practice (https://eslint.org/docs/latest/rules/no-param-reassign)
|
Waiting for approval from someone in the solo-io org to start testing. |
Charlesthebird
requested changes
Nov 5, 2024
There was a problem hiding this comment.
@alexonaci Thank you for the type updates! Once these 2 changes are accepted I can approve and publish a new release.
Co-authored-by: Nicholas Bucher <behappy54321@gmail.com>
Co-authored-by: Nicholas Bucher <behappy54321@gmail.com>
Co-authored-by: Nicholas Bucher <behappy54321@gmail.com>
Charlesthebird
approved these changes
Nov 5, 2024
|
This is now in v0.0.35 🎉 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Charlesthebird , thank you for helping with entityTransformation, I tested the functionality and added here some very small suggestions/improvements. Please let me know what you think:)
anyto deactivate type checking