Standard json type mapped from protobuf int64 is string
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for approval from someone in the solo-io org to start testing. |
cytommi
force-pushed
the
main
branch
2 times, most recently
from
5628747 to
9596e14
Compare
|
@shashankram how does this mesh or not mesh with discussions around the string versus int marshalling issues we had talked about . |
Since we primarily use this library to generate Kubernetes CRD schemas, we set use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://protobuf.dev/programming-guides/proto3/#json
Users of protojson have also been confused by encodings for int64 types being strings.
golang/protobuf#1414
This PR should ensure that the generated docs are in line with the protobuf standard.