Bump controller-runtime to v0.14.x #420
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| changelog: | ||
| - type: BREAKING_CHANGE | ||
| description: Update Status API signature to comply with controller-runtime v0.14.x API breakage | ||
| issueLink: https://github.com/solo-io/skv2/issues/419 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,10 +129,10 @@ type {{ $resource.Kind }}Writer interface { | |
| type {{ $resource.Kind }}StatusWriter interface { | ||
| // Update updates the fields corresponding to the status subresource for the | ||
| // given {{ $resource.Kind }} object. | ||
| Update{{ $resource.Kind }}Status(ctx context.Context, obj *{{ $import_prefix }}{{ $resource.Kind }}, opts ...client.SubResourceUpdateOption) error | ||
|
There was a problem hiding this comment. do you know why these had to be renamed? as far as i can tell, There was a problem hiding this comment. From kubernetes-sigs/controller-runtime#2072
So I can't comment on why these API breakages had to happen other than link to the upstream pull request, but I can say that while |
||
|
|
||
| // Patch patches the given {{ $resource.Kind }} object's subresource. | ||
| Patch{{ $resource.Kind }}Status(ctx context.Context, obj *{{ $import_prefix }}{{ $resource.Kind }}, patch client.Patch, opts ...client.SubResourcePatchOption) error | ||
| } | ||
|
|
||
| // Client knows how to perform CRUD operations on {{ $resource.Kind }}s. | ||
|
|
@@ -224,11 +224,11 @@ func (c *{{ $kindLowerCamel }}Client) Upsert{{ $resource.Kind }}(ctx context.Con | |
| return err | ||
| } | ||
|
|
||
| func (c *{{ $kindLowerCamel }}Client) Update{{ $resource.Kind }}Status(ctx context.Context, obj *{{ $import_prefix }}{{ $resource.Kind }}, opts ...client.SubResourceUpdateOption) error { | ||
| return c.client.Status().Update(ctx, obj, opts...) | ||
| } | ||
|
|
||
| func (c *{{ $kindLowerCamel }}Client) Patch{{ $resource.Kind }}Status(ctx context.Context, obj *{{ $import_prefix }}{{ $resource.Kind }}, patch client.Patch, opts ...client.SubResourcePatchOption) error { | ||
| return c.client.Status().Patch(ctx, obj, patch, opts...) | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also list the DEPENDENCY_BUMPS, particularly k8s.io/api and controller-runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, those seem reasonable. All were a consequence of pulling in controller-runtime.