Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Deployment, SA, and Service to be applied to custom Operator namespace #445

Merged
merged 10 commits into from
May 23, 2023
Merged

Allow Deployment, SA, and Service to be applied to custom Operator namespace #445

merged 10 commits into from
May 23, 2023

Conversation

jmhbh
Copy link
Contributor

@jmhbh jmhbh commented May 15, 2023 •
edited

Overview

  • The glooMeshPortalServer operator in gloo platform currently uses {{ .Release.Namespace }} which defaults to gloo-mesh we would like this to be gloo-mesh-addons instead. Therefore, by adding the Namespace field to the operator we can set this value and use it to control which namespace the deployment, service, and service account tied to the operator gets applied to.

Testing

  • Tested this in gloo platform by running make package-helm and installing gloo platform locally.

@jmhbh jmhbh force-pushed the skv2-optional-deployment-namespace branch from b1b6fd3 to fb7d434 Compare May 16, 2023 15:13
@jmhbh jmhbh changed the title Operator namespace [DO NOT MERGE] Operator namespace May 16, 2023
@jmhbh jmhbh force-pushed the skv2-optional-deployment-namespace branch from 30be6a6 to 8ef7766 Compare May 18, 2023 14:43
@jmhbh jmhbh changed the title [DO NOT MERGE] Operator namespace Allow Deployment, SA, and Service to be applied to custom Operator namespace May 18, 2023
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/gloo-mesh-enterprise/issues/9491

@jmhbh jmhbh marked this pull request as ready for review May 18, 2023 15:14
fernandosanchezs
fernandosanchezs approved these changes May 18, 2023
View reviewed changes
Copy link

@fernandosanchezs fernandosanchezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soloio-bulldozer soloio-bulldozer bot merged commit 9b1f093 into master May 23, 2023
@soloio-bulldozer soloio-bulldozer bot deleted the skv2-optional-deployment-namespace branch May 23, 2023 16:08
@jmhbh jmhbh mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelvl samuelvl samuelvl approved these changes

@fernandosanchezs fernandosanchezs fernandosanchezs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmhbh @samuelvl @fernandosanchezs