Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DeploymentOverrides and ServiceOverrides in Helm values #448

Merged
merged 3 commits into from
May 23, 2023
Merged

Expose DeploymentOverrides and ServiceOverrides in Helm values #448

merged 3 commits into from
May 23, 2023

Conversation

samuelvl
Copy link
Contributor

In order to improve our documentation, expose DeploymentOverrides and ServiceOverrides fields. For example:

glooMgmtServer:
    # Arbitrary overrides for the component's [deployment template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/)
    deploymentOverrides: null
    # Arbitrary overrides for the component's [service template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).
    serviceOverrides: null

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/gloo-mesh-enterprise/issues/9345

@samuelvl
Copy link
Contributor Author

@marcogschmidt could you take a look when you get a chance? 🙏 Based on your comment: https://github.com/solo-io/gloo-mesh-enterprise/issues/9345#issuecomment-1550105118

samuelvl
samuelvl commented May 17, 2023
View reviewed changes
codegen/cmd_test.go
@@ -237,9 +237,9 @@ var _ = Describe("Cmd", func() {

painterNode := node.Content[0].Content[1]
enabledMapField := painterNode.Content[0]
Expect(enabledMapField.HeadComment).To(Equal("# Enable creation of the deployment/service."))
Expect(enabledMapField.HeadComment).To(Equal("# Arbitrary overrides for the component's [deployment\n# template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/)"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since fields in values.yaml are alphabetical ascending ordered, deploymentOverrides description is now the first element

@soloio-bulldozer soloio-bulldozer bot merged commit c3d88a0 into master May 23, 2023
@soloio-bulldozer soloio-bulldozer bot deleted the samuelvl/overrides-docs branch May 23, 2023 15:47
samuelvl added a commit that referenced this pull request May 31, 2023
@samuelvl
Expose DeploymentOverrides and ServiceOverrides in Helm values (#448)
19e09dd
@samuelvl samuelvl mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachael-Graham Rachael-Graham Rachael-Graham approved these changes

@k8so k8so k8so approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelvl @Rachael-Graham @k8so