Manager multi version cache crds #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently kubernetes managers will fail to start cache if they are missing any crds. kubernetes-sigs/controller-runtime#1759
However when controlling many instances some which have older and some that have newer schemas we need some mechanism to not entirely stop working on the old ones. Customers pushed back on registering new CRDs on old clusters so this allows for an extended version of the manager.
As written this does not stop the reconciliation attempt on those clusters for the unknown CRDs which in turn will make the logs noisy BUT it does mean that if the remote clusters get upgraded to have the crd then we will start reconciling it immediatley.