Fix intstr.IntOrString to be number or string instead of object #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
ashleywang1
previously approved these changes
May 25, 2023
ashleywang1
approved these changes
May 25, 2023
josh-pritchard
approved these changes
May 25, 2023
soloio-bulldozer
bot
deleted the
nmatthiopoulos-9194-intstr-to-number-or-string
branch
t-edris
pushed a commit
that referenced
this pull request
Jun 2, 2023
* add intstr.IntOrStr custom handling and test * whitespace changes from codegen * add changelog * more autogenerated whitespace changes * remove more whitespaces * reset watcher.go
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
#457) * Fix intstr.IntOrString to be number or string instead of object (#453) * add intstr.IntOrStr custom handling and test * whitespace changes from codegen * add changelog * more autogenerated whitespace changes * remove more whitespaces * reset watcher.go * Move changelog to v0.30.2 --------- Co-authored-by: Nik Matthiopoulos <nikolasmatt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue where fields of type
intstr.IntOrStringwould generate schemas for an object instead of either string or number literal.Need to address issue https://github.com/solo-io/gloo-mesh-enterprise/issues/9194
Additionally after the change, code generation seems to edit a bunch of whitespaces too.
BOT NOTES:
resolves https://github.com/solo-io/gloo-mesh-enterprise/issues/9194