codegen: enable CRD schema generation using protoc-gen-openapi #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows generating CRDs schema using protoc-gen-openapi instead of Cue. This is a part of a larger effort to customize schema generation that is harder to accomplish using Cue: solo-io/gloo-mesh-enterprise#16049 Signed-off-by: Shashank Ram <shashank.ram@solo.io>
|
Issues linked to changelog: |
shashankram
force-pushed
the
shashankram/gen-crd-ext
branch
from
63c9224
to
da14a64
Compare
yuval-k
approved these changes
Apr 5, 2024
EItanya
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows generating CRDs schema using protoc-gen-openapi instead of Cue.
Although protoc-gen-openapi can be used with this change, it is not enabled by
default for backward compatibility reasons, and needs to be explicitly enabled
using the SchemaGenerator field in the GroupOptions type.
This is a part of a larger effort to customize schema generation that is harder to accomplish using Cue.
Although this can be considered a breaking change due to dependency updates, the code generation itself
is completely backward compatible and still uses Cue by default.