use slices as backing data structure for v2_sets #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
yuval-k
reviewed
Apr 9, 2024
| // Insert adds items to the set in inserted order. | ||
| // If an item is already in the set, it is overwritten. | ||
| // The set is sorted based on the ResourceId of the resources. | ||
| func (s *resourceSet[T]) Insert(resources ...T) { |
There was a problem hiding this comment.
we're changing insertion and lookup to be O(log(n))instead of O(1). Did we verify this doesn't cause perf issues?
saiskee
changed the title
yuval-k
approved these changes
Apr 10, 2024
EItanya
approved these changes
Apr 10, 2024
yuval-k
pushed a commit
that referenced
this pull request
May 20, 2024
* update * remove compare resource ids * add iter * fix iter * add iter impl * add inefficient list as cop out * add filters to inefficient list * fix inefficient list * fix inefficient list * inefficient list inverted * remove inefficient list * add length method to set/ * update * update * update v2 sets with better funciton names * update v2 sets with better funciton names * remove FilterOutAndIterate method * add Get * add comments * add changelog and remove test focus * move changelog/ * move changelog * fixes for PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOT NOTES:
resolves #543