Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: fix to prevent null strategy #550

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

samuelvl
Copy link
Contributor

Prevents the deployment strategy from being null if no condition is met:

strategy: null

For example, see test/helm/snapshots/mgmt-server-redis-1-iothreads/gloo-platform-manifest.yaml changed file in https://github.com/solo-io/gloo-mesh-enterprise/pull/16106/files

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/gloo-mesh-enterprise/issues/15710

@soloio-bulldozer soloio-bulldozer bot merged commit a8c19c8 into main Apr 24, 2024
3 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the samuelvl/fix-conditional-strategy branch April 24, 2024 14:19
samuelvl pushed a commit that referenced this pull request Apr 26, 2024
samuelvl pushed a commit that referenced this pull request Apr 26, 2024
samuelvl pushed a commit that referenced this pull request Apr 30, 2024
samuelvl pushed a commit that referenced this pull request Apr 30, 2024
…gy (#553)

* codegen: allow setting Strategy and PodSecurityContext (#538)

* codegen: support for conditional deployment strategy (#549)

* codegen: fix to prevent null strategy (#550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants