Add option to edit fullPackageName for hashing in protoc-gen-ext #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
EItanya
approved these changes
Jun 12, 2024
marcogschmidt
approved these changes
Jun 12, 2024
soloio-bulldozer
bot
deleted the
nikolasmatt/hasher-account-for-package-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a parameter to support editing the fullPackageName value used for hashing.
Context
Changing the package of the generated files has the unintended consequence of changing the hash output for messages. We need the option to edit the package name in order to maintain the old hashing logic and not cause unintentional discrepancies.
Depends on solo-io/protoc-gen-ext#23