-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster memory client #520
base: main
Are you sure you want to change the base?
Faster memory client #520
Conversation
Issues linked to changelog: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the behavior of this type is exactly the same without the clone, should the other client extend this one so we ensure the other behavior remains the same?
I think we need locks around more of the methods in this client - we should not be able to call |
Add an implementation of the memory resource client that does not clone resources as they are written and read. In gloo edge, we use the memory client to hold proxies that are only generated by the gloo pod. Because proxies can be quite large, the clones take up significant space and GC resources and we can make decisions about when clones are necessary outside of the client.