Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce arm64 compilation support #296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bltavares
Copy link

Description

When trying to install 'wasme' an a Mac M1, I was not able to find pre-compiled releases using the suggested getting started page.

This commit introduces the aarch64 binaries for Mac and Linux to make it easier for others to install 'wasme'.

Context

During the tests, when running "wasme" on a Mac, we would get a ERROR log, despite the process concluding as expected.

ERRO[0000] failure getting variant                       error="getCPUInfo for OS darwin: not implemented"

This is confusing for the user, and can be fixed by upgrading containerd as well.

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make install-deps operator-gen generated-code from tools/wasme/cli to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • [-] I have added tests that prove my fix is effective or that my feature works

When trying to install 'wasme' an a Mac M1, I was not able to find pre-compiled releases using the suggested getting started page.

This commit introduces the aarch64 binaries for Mac and Linux to make it easier for others to install 'wasme'.
When running "wasme" on a Mac, we would get a ERROR log, despite the process concluding as expected.

    ERRO[0000] failure getting variant                       error="getCPUInfo for OS darwin: not implemented"

This is confusing for the user, and can be fixed by upgrading containerd
@solo-build-bot
Copy link

solo-build-bot bot commented Nov 9, 2023

Waiting for approval from someone in the solo-io org to start testing.

@nfuden nfuden requested a review from yuval-k December 4, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant